A MySQL 8.4.0 branch with patches

While writing the previous post, I noticed that I didn't have a central location for the patches that I submitted to Oracle. Some were in local branches, some were .patch files lying around. So now I pushed a tree that has all those patches applied in a single place: patched-mysql-8.4.0, and I even added a README. This tree hopefully will make it easier to rebase on future Oracle releases. I had maintained similar branches before while pushing some of the Percona patches to Oracle around early 8.0 times.

As for the patches themselves, the majority of them add various missing features for the clone plugin to be able to support more than one transactional storage engine. There is also a compilation fix and a slightly improved AddressSanitizer support patch.

All MySQL 8.4.0 users are advised to migrate ASAP! /s

Building and testing MySQL 8.0.37 & 8.4.0 on macOS

The first MySQL LTS release, 8.4.0, is out, together with 8.0.37! Which means it's time for me to build and test them in my main work environment, continuing the series (8.3.0/8.0.36, 8.2.0/8.0.35).

The first surprise is that both these releases do not build with the current XCode (15.3 at the time of writing), because the LLVM 17 compilation failure I previously reported (#113123: Compilation fails with LLVM 17 and XCode 15.3) is not fixed yet and started affected Apple toolchain too. I am using Homebrew-packaged LLVM 16 for all the builds of these versions. I didn't do any LLVM 18 nor GCC testing neither.

For the good news, I no longer get a build-breaking warning in NDB, even though its bug (#113662) is still open. Finally, for the build-related no-news, nothing has changed with regard to system vs bundled libraries: both versions continue to build with all the system libraries, except for zlib.

On to the testsuite. It seems that 8.4.0 release build testsuite takes some 20% less time than the 8.0.37 one. It must be the payoff from the deprecated feature removal removing their tests too, although I did not try to confirm that.

Fixed bugs and no longer reproducing test failures on open bugs:

• https://bugs.mysql.com/bug.php?id=113257 (Assertion on rpl.rpl_replication_observers_example_plugin_ongoing_transaction)
• https://bugs.mysql.com/bug.php?id=113258 (TLS 1.3 tests fail)
• https://bugs.mysql.com/bug.php?id=113420 (testNdbProcess fails under ASan+UBSan)
• https://bugs.mysql.com/bug.php?id=113736 (Test main.qualify_hypergraph failing with a result difference)

New test failures:

• https://bugs.mysql.com/bug.php?id=114888 (Test innodb.parallel_read_kill always fails)
• https://bugs.mysql.com/bug.php?id=114892 (Test XComControlTest.SuspectMemberFailedRemovalDueToMajorityLoss fails)
• https://bugs.mysql.com/bug.php?id=114894 (Test rpl.rpl_log_info_repository_persistence_require_row failing)
• https://bugs.mysql.com/bug.php?id=114896 (Several tablespace encryption tests failing)

I wanted to call the following the list of bugs with no changes, but I can't. While some of the bugs indeed have no changes, there is also a small but definite creep there: a test that only failed in one configuration before now fails in two. A second sibling test started failing with same symptoms. That's definitely not "no changes", but not new independent bugs neither. It's worrying.

• https://bugs.mysql.com/bug.php?id=113189 (ColumnStatisticsTest.StoreAndRestoreAttributesEquiHeight unit test fails)
• https://bugs.mysql.com/bug.php?id=113190 (Several tests in routertest_integration_routing_sharing_constrained_pools fail)
• https://bugs.mysql.com/bug.php?id=113260 (Client error in error log: MY-004031 - The client was disconnected …)
• https://bugs.mysql.com/bug.php?id=113665 (perfschema.relaylog fails with a result difference)
• https://bugs.mysql.com/bug.php?id=113702 (Test binlog.binlog_error_action fails under Sanitizer build)
• https://bugs.mysql.com/bug.php?id=113703 (Test innodb.ddl_kill fails under Sanitizer build) - the test now fails under debug build without sanitizer too.
• https://bugs.mysql.com/bug.php?id=113704 (Test main.log_backtrace fails under Sanitizer build), but now main.log_backtrace_debug fails too, added it under the same bug.
• https://bugs.mysql.com/bug.php?id=113709 (StrXfrmTest.ChineseUTF8MB4 failing with an AddressSanitizer error), which is a duplicate of #109540, which is fixed in 8.1.0 only. There is a comment that unit tests ASan errors are not a high priority error, it's just a tiny harmless heap-buffer-overflow /s.
• https://bugs.mysql.com/bug.php?id=113710 ( Spec/HttpClientSecureTest.ensure/default_client_cipher_succeeds ASan error) - still fails on 8.0.37 but not 8.4.0. The latter shows an UBSan error though.
• https://bugs.mysql.com/bug.php?id=113722 (Test main.index_merge_innodb failing with a result difference)

I did not re-test two bugs:

• https://bugs.mysql.com/bug.php?id=113023 (mysql-test/include/wait_for_pattern_in_file.inc incompatible with Homebrew Perl)
• https://bugs.mysql.com/bug.php?id=113113 (Build failure with Homebrew LLVM 14-17 on macOS), where I keep using the workaround of setting CMAKE_AR to Homebrew ar.

Thus, the numbers are: 4 new bugs reported, 5 fixed or no longer reproducing, 10 bugs with no changes or with a bit of creep, 2 non-tested.

But wait, there's more! I have also sent some patches to Oracle by OCA! I am only counting the recent patches I developed at VilniusDB and not the ones I submitted at Percona. So how many have they applied since 8.3.0?

• https://bugs.mysql.com/bug.php?id=106737 (Wrong SE called to ack clone application if >1 SE) - nope.
• https://bugs.mysql.com/bug.php?id=106750 (Some clone tests needlessly marked as Linux-only) - nope.
• https://bugs.mysql.com/bug.php?id=107715 (Multiple SE clone not calling clone_end after mixed clone_begin failure/success) - nope.
• https://bugs.mysql.com/bug.php?id=113123 (Compilation fails with LLVM 17 and XCode 15.3) - nope.

So, zero. Of course two out of four patches are for clone with a 2nd transactional storage engine, thus the excuse of Oracle MySQL not having such engine sounds plausible.

That's about it. I am still running Valgrind tests, and they should complete any week now, unless I have to kill them to take their machine for something else. I will not be updating this post or writing a new one unless their results are very, very unexpected. Otherwise here's to the new MySQL releases and hopefully I will continue the series in three months.